From: Jonas Dreßler Date: Wed, 8 Feb 2023 15:42:18 +0000 (+0100) Subject: Add ClutterFrame arguments to after-paint signal handlers X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~405^2^2~58 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=bd202c184792d804400a662c9f15fee1b14c905b;p=gnome-shell.git Add ClutterFrame arguments to after-paint signal handlers The ClutterFrame argument was added to several signals with mutter commit 08b0e563d4d0088e19d24f3199626a2d27349d09. We have a bunch of after-paint handlers in gnome-shell too, and updating those was apparently forgotten, introducing subtle memory corruption that was luckily easy to track down by running gnome-shell with ASAN enabled. Let's fix that and add the additional argument to all the signal handlers. Part-of: --- diff --git a/src/shell-global.c b/src/shell-global.c index 0c48e0004..08b8a63e5 100644 --- a/src/shell-global.c +++ b/src/shell-global.c @@ -971,6 +971,7 @@ load_gl_symbol (const char *name, static void global_stage_after_paint (ClutterStage *stage, ClutterStageView *stage_view, + ClutterFrame *frame, ShellGlobal *global) { /* At this point, we've finished all layout and painting, but haven't diff --git a/src/shell-screenshot.c b/src/shell-screenshot.c index f7132eee8..99083ffb2 100644 --- a/src/shell-screenshot.c +++ b/src/shell-screenshot.c @@ -493,6 +493,7 @@ finish_screenshot (ShellScreenshot *screenshot, static void on_after_paint (ClutterStage *stage, ClutterStageView *view, + ClutterFrame *frame, GTask *result) { ShellScreenshot *screenshot = g_task_get_task_data (result); @@ -628,6 +629,7 @@ shell_screenshot_screenshot_finish (ShellScreenshot *screenshot, static void screenshot_stage_to_content_on_after_paint (ClutterStage *stage, ClutterStageView *view, + ClutterFrame *frame, GTask *result) { ShellScreenshot *screenshot = g_task_get_task_data (result);